Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Publish Pdb stack frames to Spyder #171

Merged
merged 6 commits into from
Jun 22, 2022
Merged

PR: Publish Pdb stack frames to Spyder #171

merged 6 commits into from
Jun 22, 2022

Conversation

impact27
Copy link
Contributor

@impact27 impact27 commented Oct 19, 2019 •
edited by ccordoba12
Loading

Enable getting and printing the current state of the console

@impact27 impact27 changed the title PR: Print current frames [Depends on #169] PR: Print current frames Oct 19, 2019
@impact27 impact27 changed the title [Depends on #169] PR: Print current frames PR: Print current frames Nov 1, 2019
@impact27 impact27 force-pushed the get_current_frames branch 4 times, most recently from 87b64bc to 4c3ef16 Compare December 31, 2019 09:08
@impact27 impact27 force-pushed the get_current_frames branch 2 times, most recently from 55e3c13 to a32d65e Compare June 30, 2020 12:35
@impact27 impact27 changed the base branch from master to 1.x July 15, 2020 12:42
@impact27 impact27 changed the base branch from 1.x to 2.x April 16, 2021 22:32
@ccordoba12 ccordoba12 changed the base branch from 2.x to master October 10, 2021 16:58
@impact27 impact27 force-pushed the get_current_frames branch 2 times, most recently from 084823d to 3ec4f9d Compare November 1, 2021 19:53
@ccordoba12 ccordoba12 removed the v2.0.0 label Jun 22, 2022
@ccordoba12 ccordoba12 added this to the v3.0.0b1 milestone Jun 22, 2022
@ccordoba12 ccordoba12 mentioned this pull request Jun 22, 2022
Merged
3 tasks
ccordoba12
ccordoba12 reviewed Jun 22, 2022
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @impact27 for your patience with this one. Besides my simple comments and suggestions, it looks good to me.

spyder_kernels/console/kernel.py Outdated Show resolved Hide resolved
spyder_kernels/console/kernel.py Outdated Show resolved Hide resolved
spyder_kernels/console/kernel.py Outdated Show resolved Hide resolved
spyder_kernels/console/shell.py Outdated Show resolved Hide resolved
spyder_kernels/customize/spyderpdb.py Outdated Show resolved Hide resolved
spyder_kernels/customize/spyderpdb.py Show resolved Hide resolved
@ccordoba12 ccordoba12 changed the title PR: Print current frames PR: Send Pdb stack frames to Spyder Jun 22, 2022
ccordoba12
ccordoba12 approved these changes Jun 22, 2022
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now, thanks @impact27!

@ccordoba12 ccordoba12 changed the title PR: Send Pdb stack frames to Spyder PR: Publish Pdb stack frames to Spyder Jun 22, 2022
@ccordoba12 ccordoba12 merged commit ece50f6 into spyder-ide:master Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccordoba12 ccordoba12 ccordoba12 approved these changes

Assignees

@impact27 impact27

Labels
None yet
Projects
None yet
Milestone
v3.0.0b1
Development

Successfully merging this pull request may close these issues.
3 participants
@impact27 @ccordoba12 @goanpeca