PR: Made compile_filename file output optional
#70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are uses cases to get the QSS compiled string from a file without having to save it to a file. This makes the `output_file` in `compile_filename` optional. If undefined it will not save the output to a file and will just return it. The documentation for `compile_filename` in the readme was duplicated so I removed the duplication.
dalthviz
changed the title
compile_filename file output optional
dalthviz
reviewed
Nov 18, 2022
There was a problem hiding this comment.
Thanks @gentlegiantJGC for the help cleaning up the README and improving the compile_file function!
The only missing thing here is to rebase this PR on top of the latest master. That should fix the errors on the CI. Let us know if you need help doing that.
Besides that this LGTM 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are uses cases to get the QSS compiled string from a file without having to save it to a file.
This makes the
output_fileincompile_filenameoptional. If undefined it will not save the output to a file and will just return it.The documentation for
compile_filenamein the readme was duplicated so I removed the duplication.