Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Constraint libsass to 0.21.0 and update .authors.yml file #68

Merged
merged 2 commits into from
Sep 15, 2022

Conversation

dalthviz
Copy link
Member

@dalthviz dalthviz commented Sep 14, 2022

  • Add constraint for libsass<=0.21.0 since seems like a new version will drop support for Python 2.7 (which is currently supported here).
  • Update .authors.yml file to include missing entry.

Part of #67

@dalthviz dalthviz added this to the v0.3.2 milestone Sep 14, 2022
@dalthviz dalthviz self-assigned this Sep 14, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2022

Codecov Report

Merging #68 (c0057dc) into master (c657390) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #68   +/-   ##
=======================================
  Coverage   87.52%   87.52%           
=======================================
  Files          12       12           
  Lines         513      513           
=======================================
  Hits          449      449           
  Misses         64       64           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @dalthviz!

@ccordoba12
Copy link
Member

@dalthviz, as you mentioned before, I think it's a good idea to mark test_watchers as flaky to avoid failures in our test suite.

Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now, thanks @dalthviz!

@ccordoba12 ccordoba12 merged commit 03d4326 into spyder-ide:master Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants