Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Add mappings for deprecated QDropEvent pos and posF methods #445

Merged
merged 2 commits into from
Aug 17, 2023
Merged

PR: Add mappings for deprecated QDropEvent pos and posF methods #445

merged 2 commits into from
Aug 17, 2023

Conversation

dalthviz
Copy link
Member

@dalthviz dalthviz commented Aug 16, 2023 •
edited
Loading

Mappings for pos and posF for QDropEvent also affect child classes (QDragMoveEvent, QDragEnterEvent). A mapping to have position over Qt5 bindings is done too.

Part of #442

@dalthviz dalthviz added this to the v2.4.0 milestone Aug 16, 2023
@dalthviz dalthviz self-assigned this Aug 16, 2023
@dalthviz dalthviz closed this Aug 16, 2023
@dalthviz dalthviz reopened this Aug 16, 2023
@dalthviz dalthviz changed the title [WIP] PR: Add mappings for deprecated QDropEvent pos and posF methods PR: Add mappings for deprecated QDropEvent pos and posF methods Aug 16, 2023
@dalthviz dalthviz marked this pull request as ready for review August 16, 2023 18:20
@ccordoba12
Copy link
Member

@dalthviz, I only have one question for you: will this fix the bug reported in jupyter/qtconsole#583?

@dalthviz
Copy link
Member Author

@ccordoba12 I believe so. With the changes here the pos method is added to the QDragMoveEvent via the addition of the method to the class it inherits from (QDropEvent). Not sure if there are other event classes involved in the QtConsole issue but at least this should prevent the traceback reported at jupyter/qtconsole#583 (comment)

ccordoba12
ccordoba12 approved these changes Aug 17, 2023
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dalthviz!

@ccordoba12 ccordoba12 merged commit bada0d7 into spyder-ide:master Aug 17, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccordoba12 ccordoba12 ccordoba12 approved these changes

Assignees

@dalthviz dalthviz

Labels
type:Enhancement
Projects
None yet
Milestone
v2.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dalthviz @ccordoba12