Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Make CI jobs much faster & less flaky w/Mamba, 1-pass solve & other tweaks #425

Merged
merged 3 commits into from
Apr 10, 2023

Conversation

CAM-Gerlach
Copy link
Member

@CAM-Gerlach CAM-Gerlach commented Apr 9, 2023

As originally prompted by the fix recommended in conda/conda#12390 for the CI issue in #423 , this will use Mamba rather than Conda on the CIs, which not only has stable, accurate solves avoiding that issue and other potential similar ones, but also speeds up the Conda=yes jobs (which are currently the slowest) by around ≈2x total, and should also avoid the timeout/hang issues we sometimes see especially on macOS (and occasionally Windows).

Also:

  • Create the environment for each binding and install packages all in one pass, rather than a separate install step for Qt/bindings, for a further substantial speedup
  • Use a unique environment name for each binding to avoid needing to remove the environment before creating it
  • Tweak various shell options for CI bash commands/scripts

Fixes #423

@CAM-Gerlach CAM-Gerlach self-assigned this Apr 9, 2023
@CAM-Gerlach CAM-Gerlach force-pushed the ci-use-mamba branch 2 times, most recently from 2f0ce55 to d272dac Compare April 9, 2023 05:14
@CAM-Gerlach CAM-Gerlach force-pushed the ci-use-mamba branch 2 times, most recently from c72216e to 1327d53 Compare April 9, 2023 05:50
@CAM-Gerlach CAM-Gerlach changed the title PR: Use Mamba to greatly speed up CI jobs and avoid flaky resolution issues PR: Make CI jobs much faster & less flaky w/Mamba, 1-pass solve & other tweaks Apr 9, 2023
@CAM-Gerlach CAM-Gerlach added this to the v2.4.0 milestone Apr 9, 2023
@CAM-Gerlach CAM-Gerlach marked this pull request as ready for review April 9, 2023 06:47
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @CAM-Gerlach!

Copy link
Member

@dalthviz dalthviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CAM-Gerlach !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix flaky importlib error on Ubuntu Python 3.7 conda CI job
3 participants