-
-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Add mappings for QMouseEvent methods #408
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good so far, thanks, but would it be possible to actually test that the functions can be called correctly and consistently? That seems to be the user's concern on that issue. Thanks!
It looks like the test crashes the process on Ubuntu with For the issue with Ubuntu, the most related thread I found on SO was https://stackoverflow.com/questions/56281631/qapplication-instance-qtbot-fixture-causes-travis-ci-to-abort-and-core-dump. Maybe, it'll help.
Oh, wow, I get the same crash in GitHub tests when I create an instance of I had to skip the test for the config for now. And I can't actually get the coordinates I move the mouse to from the event methods. I can't predict the window border dimensions. Possibly, I missed something. Anyway, the mapping I use should prevent any default values (like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks generally good to me, thanks, aside from another minor nit; for more substantive expert feedback I would defer to @dalthviz
See spyder-ide#408 (comment) Co-authored-by: C.A.M. Gerlach <[email protected]>
`QMainWindow.show()` finishes when the window appears. So, no extra waiting needed.
This reverts commit 966be08.
…qt` crashes" This reverts commit e90bb1a.
(Sidenote: @dalthviz , if/when this is merged, it should be presumably done via the Squash strategy (or with rebase cleanup first) to avoid all the repeated fixup commits for a relatively small change. I enabled a setting that will still preserve a list of the commit messages in the commit description, and the full commit history of this branch can still be referred to on the PR in perpetuity, while the history on the main branch is kept clean.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @StSav012 for your work here! Besides that seems like there is a change from a PR #407 also here, this LGTM 👍
Do you know what could have happened there @CAM-Gerlach? Also, feel free to squash merge this when you think is ready (seems like there a unresolved conversation)
See spyder-ide#408 (comment) Co-authored-by: C.A.M. Gerlach <[email protected]>
Added
for PyQt6 and PySide6.
And I had to add
to PyQt5 and PySide2 to make the event test universal and (consequently, but this was not the required enhancement) bidirectional. This way, I check that the coordinates returned by the back-ported functions are equal to what the Qt6 functions return (except for the type, but I use integer coordinates for that to work).