-
-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Add QtPdf
and QtPdfWidgets
#382
Conversation
00cfb36
to
7eb9194
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jschueller for helping with this! Checking, I think that the QtPdf
and QtPdfWidgets
modules are only available in PyQt6 and PySide6 >=6.4.0. Taking that into account, maybe we should put in place a try-catch for the PyQt6 and PySide6 import calls and raise a QtBindingMissingModuleError
in case of an ImportError
? What do you think?
Beside that, could you rebase on top of the latest master, please? That should fix the failing test.
Other than the above this LGTM 👍
Closes spyder-ide#381
ok, I rebased |
Thanks for the quick response! And regarding raising |
thtat's not what is done for other modules, let's keep it simple |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again @jschueller for your help with this! Thinking a little bit more, there is no need to hold this for being merged. Indeed, keeping things simple is better, and actually there is no qtpy error implemented that encapsulates the case of a module not being available in a specific binding version (maybe in the future we could add it but for the moment the ModuleNotFoundError
should be fine 👍🏼 )
Closes #381