PR: toPython helpers for QDate and QTime #361
Conversation
CAM-Gerlach
changed the title
There was a problem hiding this comment.
Seems naively reasonable to me overall, but I'd defer to @dalthviz on that.
Could you either add tests like the one for QDateTime.toPython (or parameterize that test accordingly)?
Missed a step that didn't get caught in testing for some reason. Co-authored-by: CAM Gerlach <[email protected]>
There was a problem hiding this comment.
Hi @bob-schumaker thank you for working on this! I would say that the missing thing here is to add some tests for QDate.toPython and QTime.toPython as @CAM-Gerlach mentioned. If you need help with that let us know!
Other than that this LGTM 👍
Duh, out of practice. Let me add the tests :-) |
This adds toPython() compat functions to QDate and QTime for symmetry.