-
-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Fix uic skipped tests and PyQt 6.3.0 segfaulting tests #335
Conversation
55d55ea
to
07f285b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks @dalthviz!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, @dalthviz —always good when we can unskip tests! I had one small tweak to update the skip reason now that it isn't CI-specific, otherwise LGTM
Co-authored-by: CAM Gerlach <[email protected]>
4c8a671
to
fab767a
Compare
Co-authored-by: CAM Gerlach <[email protected]>
9939841
to
88b3961
Compare
88b3961
to
6893baf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now, thanks @dalthviz !
Fixes #265
Fixes #336