PR: Restrict broken Pytest versions to those not affected by the Pytest 7.0.0 import-mode=importlib behavior regression #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CAM-Gerlach
changed the title
CAM-Gerlach
force-pushed
the
fix-pytest-7-regression
branch
from
7c5e01f
to
418d48b
Compare
CAM-Gerlach
force-pushed
the
fix-pytest-7-regression
branch
from
418d48b
to
383b78b
Compare
CAM-Gerlach
force-pushed
the
fix-pytest-7-regression
branch
from
383b78b
to
d9dc0be
Compare
CAM-Gerlach
changed the title
dalthviz
approved these changes
Feb 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presently, Pytest's
--importmode=importlibcauses our test suite to fail at collection due to a regression introduced in Pytest 7.0.0, pytest-dev/pytest#9645 . This was fixed in pytest-dev/pytest#9681 , but hasn't yet made it into a Pytest release. Therefore, we work around it for now by disabling--importmode=importlib.Fixes #323