Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Add QtCharts alias for backward compatibility with 1.x #315

Merged
merged 3 commits into from
Jan 20, 2022

Conversation

dalthviz
Copy link
Member

@dalthviz dalthviz commented Jan 17, 2022

Fixes #304

Note: Needs a rebase after #313 is merged

@dalthviz dalthviz added this to the v2.0.1 milestone Jan 17, 2022
@dalthviz dalthviz self-assigned this Jan 17, 2022
@dalthviz dalthviz changed the title PR: Add QtCharts alias for backward compatibility with 1.x [WIP] PR: Add QtCharts alias for backward compatibility with 1.x Jan 17, 2022
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because you're importing QtCharts in init, this makes the separate QtCharts module a hard dependency of QtPy, instead of just users importing qtpy.QtCharts, This also causes our tests to fail on platforms that don't have it by default, on which the test would normally be skipped (aside from the coverage-related failure you fixed in #313 ). Can you do this manipulation inside qtpy.QtCharts instead of in `init to resolve this issue? Thanks!

@CAM-Gerlach
Copy link
Member

@dalthviz Just curious—is there a reason for using the the manual [WiP] title "tag" instead of marking as draft?

@dalthviz
Copy link
Member Author

@dalthviz Just curious—is there a reason for using the the manual [WiP] title "tag" instead of marking as draft?

Pure habit basically

@dalthviz dalthviz changed the title [WIP] PR: Add QtCharts alias for backward compatibility with 1.x PR: Add QtCharts alias for backward compatibility with 1.x Jan 18, 2022
qtpy/__init__.py Outdated Show resolved Hide resolved
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now, thanks @dalthviz!

Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @dalthviz !

@CAM-Gerlach CAM-Gerlach merged commit 74dd309 into spyder-ide:master Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Qt6: QtCharts namespace incompatibility
3 participants