PR: Add QtCharts alias for backward compatibility with 1.x
#315
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalthviz
changed the title
QtCharts alias for backward compatibility with 1.xQtCharts alias for backward compatibility with 1.x
CAM-Gerlach
requested changes
Jan 18, 2022
There was a problem hiding this comment.
Because you're importing QtCharts in init, this makes the separate QtCharts module a hard dependency of QtPy, instead of just users importing qtpy.QtCharts, This also causes our tests to fail on platforms that don't have it by default, on which the test would normally be skipped (aside from the coverage-related failure you fixed in #313 ). Can you do this manipulation inside qtpy.QtCharts instead of in `init to resolve this issue? Thanks!
|
@dalthviz Just curious—is there a reason for using the the manual |
Pure habit basically |
dalthviz
force-pushed
the
fixes_issue_304
branch
from
7f4bc10
to
3b6735d
Compare
dalthviz
changed the title
QtCharts alias for backward compatibility with 1.xQtCharts alias for backward compatibility with 1.x
ccordoba12
reviewed
Jan 18, 2022
ccordoba12
approved these changes
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #304
Note: Needs a rebase after #313 is merged