Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Add mapping for missing enum values aliases on QtCore.Qt #314

Merged
merged 3 commits into from
Jan 18, 2022

Conversation

dalthviz
Copy link
Member

@dalthviz dalthviz commented Jan 14, 2022

Fixes #306

Note: Needs a rebase after #313 is merged

@dalthviz dalthviz added this to the v2.0.1 milestone Jan 14, 2022
@dalthviz dalthviz self-assigned this Jan 14, 2022
@dalthviz dalthviz changed the title PR: Add mapping for missing enum values aliases on QtCore.Qt [WIP] PR: Add mapping for missing enum values aliases on QtCore.Qt Jan 14, 2022
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dalthviz ! A few trivial things.

qtpy/QtCore.py Outdated Show resolved Hide resolved
qtpy/QtCore.py Outdated Show resolved Hide resolved
qtpy/tests/test_qtcore.py Outdated Show resolved Hide resolved
CAM-Gerlach
CAM-Gerlach previously approved these changes Jan 18, 2022
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my end, at least, though there could be some more advanced Qt issues I'm missing.

EDIT: And the failing tests...investigation in progress.

EDIT 2: Oops, its just the coverage issue you fixed before in #313 that we literally just talked about...my memory is not so good, lol.

@CAM-Gerlach CAM-Gerlach dismissed their stale review January 18, 2022 01:27

Didn't see the failing tests

Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @dalthviz ! Now that #313 is merged you can rebase this

@dalthviz dalthviz changed the title [WIP] PR: Add mapping for missing enum values aliases on QtCore.Qt PR: Add mapping for missing enum values aliases on QtCore.Qt Jan 18, 2022
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dalthviz!

@ccordoba12 ccordoba12 merged commit de2aaa4 into spyder-ide:master Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Qt6: missing unscoped enum values
3 participants