Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Fix QFileSystemModel for PyQt6 #303

Merged
merged 1 commit into from
Dec 21, 2021
Merged

Conversation

almarklein
Copy link
Contributor

@almarklein almarklein commented Dec 21, 2021

For some reason they moved it to QtGui.

FWIW, I'm doing some CI builds for Pyzo, and the one for Linux/py39/PyQt6 broke on this. After the proposed change, it worked. Also see https://stackoverflow.com/questions/66872811/is-the-icon-functionality-of-qfilesystemmodel-broken-in-pyqt6-on-windows?noredirect=1&lq=1

For some reason they moved it to QtGui.
@dalthviz dalthviz added this to the v2.0.0 milestone Dec 21, 2021
@dalthviz dalthviz changed the title Fix QFileSystemModel for PyQt6 PR: Fix QFileSystemModel for PyQt6 Dec 21, 2021
Copy link
Member

@dalthviz dalthviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @almarklein for helping with this! LGTM 👍

@dalthviz dalthviz merged commit ae5cc22 into spyder-ide:master Dec 21, 2021
@almarklein almarklein deleted the patch-1 branch December 21, 2021 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants