-
-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Update RELEASE.md for 1.x version #293
Conversation
Per discussion with @dalthviz , given there are some important additions here that would be very useful in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dalthviz for the great improvements! LGTM now that I synced the additions and improvements with those in master
, minus a few master
-specific things. @ccordoba12 and @dalthviz , would you mind reviewing? Once this is ready, I can take care of the merge, as there are a few things (a couple more than I initially thought) that I'll need to take care of when merging to master
. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @CAM-Gerlach for the changes! LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks @dalthviz and @CAM-Gerlach!
You will take care of the merge with master right @CAM-Gerlach ? |
Yup, in work now |
Just in case @CAM-Gerlach I merged #278 (maybe that can affect the merge you started doing 😅 ) |
Yeah, you could say it "affected" it...if by "affected" you mean blocked me when I tried to push and forced me to start over since it created new commits on upstream between the time I started the merge and when I finished 😆 It wasn't that bad, I did some juGitsu and managed to not have to do everything over, just the Git parts haha, just FYI next time let's maybe not merge something to master at the same time, hmm? 😉 |
In all seriousness, it took me longer to write that than actually fix the problem jaja, no worries |
Also, separately merged the release per the new release guide |
Update
RELEASE.md
following current branch structure (master
and1.x
) and add some missing info