-
-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Add warning for deprecated/EoL Qt5 & PyQt5/PySide2 versions to fix #284 #289
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @CAM-Gerlach for the help with this! I left some questions/suggestions. Regarding the merge with master, sounds go to me if do it (after merging this then you can go ahead with that 👍)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks @CAM-Gerlach for your work on this!
ca1e01d
to
aa44fea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @CAM-Gerlach for your help with this!
Thanks @dalthviz and @ccordoba12 for the reviews and feedback! Taking care of the |
Seems like there's some weird behavior with Win 10 + PyQt 5.9 + conda + Python 3.6, where the tests pass, but when we run the command to save the path for the test coverage, which imports QtPy a second time, |
As discussed in #284 , adds a
DeprecationWarning
on QtPy 1.x for Qt5/PyQt5 versions below 5.9 and PySide2 versions below 5.12.@dalthviz the merge to 1.x will be rather non-trivial (replacing distutils with packaging, changing the warning type, fixing merge conflicts, and possibly a tweak to the message to include users as well, etc) so I'm happy to take care of that too, if you'd like.
Closes #284