Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Catch PythonQtError when trying to do alias for QtDataVisualization and dev version correction #281

Merged
merged 1 commit into from
Nov 17, 2021

Conversation

dalthviz
Copy link
Member

@dalthviz dalthviz commented Nov 17, 2021

Fixes #280

Version: Correct dev version to reflect being 1.x
@dalthviz dalthviz added this to the v1.11.3 milestone Nov 17, 2021
@dalthviz dalthviz self-assigned this Nov 17, 2021
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @dalthviz!

@dalthviz dalthviz merged commit 7ba1e0e into spyder-ide:1.x Nov 17, 2021
@dalthviz dalthviz linked an issue Nov 17, 2021 that may be closed by this pull request
dalthviz added a commit that referenced this pull request Nov 17, 2021
@CAM-Gerlach
Copy link
Member

CAM-Gerlach commented Nov 17, 2021

FYI @dalthviz , this was milestoned for v1.11.3, but the version attribute was set to 1.12.0...which one did you intend?

@dalthviz
Copy link
Member Author

Hi @CAM-Gerlach 1.12.0.dev0 is the dev version for the branch, on release this will change to be 1.11.3 and then add the end of the release will go back to 1.12.0.dev0 and no further release will be done from that branch (it is a similar approach as the one in Spyder with the 4.x branch where the dev version has the incremented minor i.e 4.3.0.dev0 and the latest release was 4.2.5)

@CAM-Gerlach
Copy link
Member

Huh, that wasn't how I remember it used to be with Spyder before. Unless I'm misunderstanding something, its kinda strange to use a dev version that is knowingly higher than the intended release version from the same branch before that version is released, such that the version of the previous dev version will sort higher than the future release version from the same branch, i.e. a current checkout would be considered a later version despite coming before the 1.11.3 release to which it is actually an ancestor. Would seem to violate valid PEP 440 versioning practices, though the impact is limited by the fact that its only a dev version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

import qtpy raise except when only have PyQt4
3 participants