Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Use modern packaging instead of deprecated distutils for version parse #266

Merged
merged 1 commit into from
Oct 28, 2021

Conversation

CAM-Gerlach
Copy link
Member

Replaces using the deprecated distutils for version comparison with the modern standard replacement packaging, and adds the latter to the install_requires.

Fixes #234
Closes #235 (supersedes it)

@CAM-Gerlach CAM-Gerlach self-assigned this Oct 28, 2021
@CAM-Gerlach
Copy link
Member Author

Would be good to merge PR #262 first, so we can rebase this on that just to be 100% sure everything still works on the new platforms/versions and stricter build and test process.

Copy link
Member

@dalthviz dalthviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CAM-Gerlach ! This LGTM 👍

Also, after merging this, could you update PR #262 to have this changes? Thanks!

@dalthviz dalthviz merged commit c5212c3 into spyder-ide:master Oct 28, 2021
@CAM-Gerlach
Copy link
Member Author

I would normally do that, but the only problem is if I do so on that PR, I would lose all the CI runs for each individual commit that I took great care to preserve when rebaseing that one, keeping a record of the CI output and behavior after each significant change. That said, it is pretty unlikely that this would pass on the old CIs and fail on the new ones, given its such a small change, and with that PR the CIs will run on push as well (to catch these sorts of situations) and notify us right away (which I will be watching for), in which case I can immediately follow up with a fix.

@CAM-Gerlach CAM-Gerlach deleted the replace-distutils-packaging branch December 1, 2021 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

distutils.LooseVersion is being deprecated
2 participants