PR: Wait (blocking) for data when using PtyProcess #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously PtyProcess thread was using non-blocking calls to read which was effectively caused high-CPU usage, which was partially mitigated by time.sleep(0.1). NOTE: When console process dies the pipe gets closed, causing read to return as well. Also, removed superfluous `pty = pty_fixture()` calls from PtyProcess that made tests hang with blocking approach on `cmd.exe`.
|
Thanks! This change LGTM, but will need to wait for some build chain updates for CI to pass. cf #90 (comment) |
|
@blink1073 @ccordoba12 Great! Thanks for the positive review. Cheers, Adam. |
|
Thank you for your fix! The cpu usage improved a lot immediately! I copied the changes over manually although some checks were not successful. Before it was not possible to use the terminal over a long time. |
|
What's the status of this PR? Is there anything I can do to help get this merged? |
|
We need to fix our testing infrastructure here, due to changes in how We hope to start working on it next week. |
Merge with upstream
ccordoba12
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is alternative solution to the problem described at jupyter/terminado#54 and pull request workaround #94.
Instead of doing any
time.sleepPtyProcessread thread it is simply blocking waiting forstdoutdata. When the underlyiung console process dies, console pipe gets closed so read exits as well.Notes
I have tested it with
pytestand manually using JupyterLab console.Commit notes
Previously PtyProcess thread was using non-blocking calls to read which
was effectively caused high-CPU usage, which was partially mitigated
by time.sleep(0.1).
NOTE: When console process dies the pipe gets closed, causing read to
return as well.
Also, removed superfluous
pty = pty_fixture()calls from PtyProcessthat made tests hang with blocking approach on
cmd.exe.