Skip to content

Commit

Permalink
Use a saner requirements for python-dateutil
Browse files Browse the repository at this point in the history
The requirement >=1.0, <2.0, >=2.1 doesn't make a lot of logical sense and it
will break in the future. There is no version that is >= 1.0, and < 2.0, and
>= 2.1 becasue these versions are mutually exclusive. Even if you interpret
the , as OR it still doesn't make sense because this includes every version.

What this spec is actually trying to represent is any version >= 1.0 but not
2.0, so instead we'll just say that.
  • Loading branch information
dstufft committed Nov 19, 2014
1 parent 394b4c4 commit 15c7cc3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
requires = ['six']

if sys.version_info[0] == 2:
requires += ['python-dateutil>=1.0, <2.0, >=2.1']
requires += ['python-dateutil>=1.0, != 2.0']
else:
# Py3k
requires += ['python-dateutil>=2.0']
Expand Down

6 comments on commit 15c7cc3

@chriso
Copy link

@chriso chriso commented on 15c7cc3 Dec 23, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just ran into this issue. pip will no longer install freezegun as of v6. Can a new release be tagged with this fix?

@inlinestyle
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@thieman
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 new release

@spulec
Copy link
Owner

@spulec spulec commented on 15c7cc3 Dec 25, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New release pushed

@inlinestyle
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hooray! Thank you!

@thieman
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a Christmas miracle!

Please sign in to comment.