Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACP-2521 Added SalesPaymentDetail docs and update Stripe docs. #2574

Conversation

stereomon
Copy link
Contributor

@stereomon stereomon commented Mar 20, 2024

PR Description

  • Added SalesPaymentDetail module integration and usage.
  • Updated Stripe guide with SalesPaymentDetail.

Checklist

  • I agree with the Code Contribution License Agreement in CONTRIBUTING.md

@stereomon stereomon added new PR contains a new document updated PR contains meaningful changes to some document labels Mar 20, 2024
matweew
matweew previously approved these changes Mar 20, 2024
@@ -0,0 +1,102 @@
---
title: Payment details of third party integrations
description: Find out about how to use payment details from a third-party payment service provider in your Spryker shop.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: Find out about how to use payment details from a third-party payment service provider in your Spryker shop.
description: Find out about how to save payment details from a third-party payment service provider in your Spryker shop.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is about usage and not about how it gets persisted (save).


## 5. Usage

When payment is creating using a third-party payment service provider which supports this feature, you will receive asynchronous messages about the payment. When you want to use this data of the `spy_sales_payment_detail` table, you need to combine the data from this table with the entity you are fetching from the database where this payment detail is related to.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make this a more clear message by rewriting/breaking down into more sentences

---
title: Retrieve and use payment details from third-party payment providers
description: Learn how to retrieve and use payment details from a third-party payment service providers
draft: true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be published or just merged?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be published as well

@andriitserkovnyi andriitserkovnyi merged commit 84ca1af into master Mar 27, 2024
7 of 9 checks passed
@andriitserkovnyi andriitserkovnyi deleted the feature/acp-2521/master-stripe-app-save-stripe-psp-details-in-scos branch March 27, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new PR contains a new document updated PR contains meaningful changes to some document
Development

Successfully merging this pull request may close these issues.

3 participants