Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended output for schema validation #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

newLoki
Copy link
Contributor

@newLoki newLoki commented Aug 3, 2023

PR Description

Currently the output of the schema validation command only shows the issue, but gives no further description where exactly it appears. This pull request will at least show which element, meaning column definition, is causing the validation issue to be able to find a quicker solution.

Even better would be to show the table + column that is affected, but the information which table is validated is not available in the check.

grafik

Checklist

  • I agree with the Code Contribution License Agreement in CONTRIBUTING.md

- add the element name that has a validation error to avoid going through all columns of a schema file
@spryker-release-bot
Copy link
Collaborator

Thank you for providing a pull request to our repository. Can we ask you to complete this 2-question form?
https://www.surveymonkey.de/r/PPNJ5L8

This will help us evaluate and merge your pull request as soon as possible, as well as make sure your contribution is properly recognized.
After sending your answer, our developers will check your PR and reach out to you using the email provided below with clarifying questions and an ETA on when you can expect your contribution to be merged with our core code.

In the meantime, please check that:

  • Your code is free of side effects that could harm other use cases.
  • Your code is tested, ideally a small test case provided along side the change to show the issue is indeed fixed and no regression can sneak in.

With this we can process it even faster and will be able to deliver the fixed module(s) to you with highest quality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants