Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue PHP Fatal error: Call to a member function getImage() on bool in ModuleConstantsFormingConstantValuesRule.php:47 #125

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

vitaliiivanovspryker
Copy link
Contributor

@vitaliiivanovspryker vitaliiivanovspryker commented Jan 2, 2024

PR Description

  • fixes issue with scanning Shared constant files that contain boolean or integers values

Resolves:

#124
https://spryker.atlassian.net/browse/FRW-7055
TBD

Checklist

  • I agree with the Code Contribution License Agreement in CONTRIBUTING.md

Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (705f2f2) 35.19% compared to head (159dd9c) 35.22%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #125      +/-   ##
============================================
+ Coverage     35.19%   35.22%   +0.02%     
- Complexity      844      845       +1     
============================================
  Files            86       86              
  Lines          2307     2308       +1     
============================================
+ Hits            812      813       +1     
  Misses         1495     1495              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vitaliiivanovspryker vitaliiivanovspryker merged commit 22537ee into spryker:master Jan 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant