Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TE-10562 Added rule to check deprecated usage of decodeJson() #114

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

yaroslav-spryker
Copy link
Contributor

@yaroslav-spryker yaroslav-spryker commented Apr 5, 2022

PR Description

Added rule to check deprecated usage of decodeJson() from bridges.
Ticket: https://spryker.atlassian.net/browse/TE-10562

Checklist

  • I agree with the Code Contribution License Agreement in CONTRIBUTING.md

@codecov
Copy link

codecov bot commented Apr 5, 2022

Codecov Report

Merging #114 (feb08ca) into master (4a29a06) will increase coverage by 0.85%.
The diff coverage is 92.10%.

@@             Coverage Diff              @@
##             master     #114      +/-   ##
============================================
+ Coverage     34.78%   35.63%   +0.85%     
- Complexity      840      854      +14     
============================================
  Files            86       88       +2     
  Lines          2067     2099      +32     
============================================
+ Hits            719      748      +29     
- Misses         1348     1351       +3     
Impacted Files Coverage Δ
...mon/Method/DeprecatedObjectUsageJsonDecodeRule.php 89.28% <89.28%> (ø)
src/Common/Bridge/BridgeMethodsInterfaceRule.php 83.80% <100.00%> (ø)
src/Common/Bridge/BridgeMethodsRule.php 87.09% <100.00%> (ø)
src/Common/Bridge/BridgeNameRule.php 77.77% <100.00%> (-0.61%) ⬇️
src/Common/ClassNameTrait.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a29a06...feb08ca. Read the comment docs.

@dereuromark
Copy link
Contributor

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants