Skip to content

Commit

Permalink
Merge pull request #129 from spryker/feature/frw-8801/master-php-upgr…
Browse files Browse the repository at this point in the history
…ade-and-drop-81

FRW-8801 Dropped PHP 8.0 support.
  • Loading branch information
asmarovydlo authored Sep 19, 2024
2 parents f2b5560 + 3d54a0e commit 96eae11
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 14 deletions.
16 changes: 6 additions & 10 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ jobs:
fail-fast: false
matrix:
php-version: [
'8.0',
'8.2'
'8.1',
'8.3'
]

steps:
Expand Down Expand Up @@ -51,15 +51,11 @@ jobs:
- name: Codeception tests
run: |
if [[ ${{ matrix.php-version }} == '8.0' ]]; then
vendor/bin/codecept build
XDEBUG_MODE=coverage vendor/bin/codecept run --coverage-xml
else
composer test
fi
vendor/bin/codecept build
XDEBUG_MODE=coverage vendor/bin/codecept run --coverage-xml
- name: Code Coverage Report
if: success() && matrix.php-version == '8.0'
if: success()
uses: codecov/codecov-action@v1

- name: PHPStan checks
Expand All @@ -74,7 +70,7 @@ jobs:
fail-fast: false
matrix:
php-version: [
'8.0'
'8.1'
]

steps:
Expand Down
3 changes: 1 addition & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
[![CI](https://github.com/spryker/architecture-sniffer/workflows/CI/badge.svg?branch=master)](https://github.com/spryker/architecture-sniffer/actions/workflows/ci.yml)
[![Coverage](https://codecov.io/gh/spryker/architecture-sniffer/branch/master/graph/badge.svg?token=4AKCKMRg3G)](https://codecov.io/gh/spryker/architecture-sniffer)
[![Latest Stable Version](https://poser.pugx.org/spryker/architecture-sniffer/v/stable.svg)](https://packagist.org/packages/spryker/architecture-sniffer)
[![Minimum PHP Version](http://img.shields.io/badge/php-%3E%3D%208.0-8892BF.svg)](https://php.net/)
[![Minimum PHP Version](http://img.shields.io/badge/php-%3E%3D%208.1-8892BF.svg)](https://php.net/)
[![License](https://poser.pugx.org/spryker/architecture-sniffer/license.svg)](https://packagist.org/packages/spryker/architecture-sniffer)
[![Total Downloads](https://poser.pugx.org/spryker/architecture-sniffer/d/total.svg)](https://packagist.org/packages/spryker/architecture-sniffer)

Expand Down Expand Up @@ -92,7 +92,6 @@ Don't forget to test your changes:
```
php phpunit.phar
```

### Running code-sniffer on this project
Make sure this repository is Spryker coding standard conform:
```
Expand Down
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"homepage": "https://spryker.com",
"license": "MIT",
"require": {
"php": ">=8.0",
"php": ">=8.1",
"laminas/laminas-config": "^2.5.1 || ^3.1.0",
"laminas/laminas-filter": "^2.5.1",
"phpdocumentor/reflection-docblock": "^5.3.0",
Expand Down
2 changes: 1 addition & 1 deletion src/Node/DocBlock/CustomTags/ModuleTag.php
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ class ModuleTag extends BaseTag implements StaticMethod
/**
* @var string
*/
protected $name = 'module';
protected string $name = 'module';

/**
* @param \phpDocumentor\Reflection\DocBlock\Description|null $description
Expand Down

0 comments on commit 96eae11

Please sign in to comment.