Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FRW-8773 Added PHPUnit 11 support. #68

Merged
merged 5 commits into from
Nov 4, 2024
Merged

FRW-8773 Added PHPUnit 11 support. #68

merged 5 commits into from
Nov 4, 2024

Conversation

olhalivitchuk
Copy link
Contributor

@olhalivitchuk olhalivitchuk commented Oct 18, 2024 •
edited
Loading

Release Table

Module Release Type Constraint Updates
Evaluator patch (currently 0.x)

Module Evaluator

Change log

Improvement

  • Added PHPUnit 11 support.

Adjustments

  • Increased nikic/php-parser module version dependency.

@olhalivitchuk olhalivitchuk added the enhancement New feature or request label Oct 18, 2024
asmarovydlo
asmarovydlo suggested changes Oct 28, 2024
View reviewed changes
Copy link

@asmarovydlo asmarovydlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix PR title

  • PHP Unit !== PHPUnit

Please fix changelogs

  • PHP Unit !== PHPUnit
  • It is not an Initial release for the module
  • Please move Increased nikic/php-parser module version dependency. to Adjustments section, the rest should stay in Improvement section

@olhalivitchuk olhalivitchuk changed the title FRW-8773 Added PHP Unit 11 support. FRW-8773 Added PHPUnit 11 support. Oct 28, 2024
@olhalivitchuk olhalivitchuk merged commit fb6781c into master Nov 4, 2024
4 checks passed
@olhalivitchuk olhalivitchuk deleted the feature/frw-8773/master-upgraded-phpunit-and-codeception-versions branch November 4, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kraal-spryker kraal-spryker kraal-spryker approved these changes

@asmarovydlo asmarovydlo asmarovydlo approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@olhalivitchuk @asmarovydlo @kraal-spryker