SDK-4713: Extract utils #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VladislavStrelchenko
requested review from
sergeyspryker and
DmytroKlymanSpryker
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #53 +/- ##
============================================
- Coverage 88.46% 88.16% -0.30%
+ Complexity 567 549 -18
============================================
Files 77 72 -5
Lines 1707 1656 -51
============================================
- Hits 1510 1460 -50
+ Misses 197 196 -1
☔ View full report in Codecov by Sentry. |
DmytroKlymanSpryker
suggested changes
Nov 13, 2023
src/ReleaseApp/Infrastructure/Configuration/ConfigurationProvider.php
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Looks good. Please check @DmytroKlymanSpryker's comments.
Although, service declaration for 2 services in 3 lines instead of 2 looks a bit overengineerd. Maybe, we can get read of Interface if there's only one service class.
DmytroKlymanSpryker
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://spryker.atlassian.net/browse/SDK-4713