SDK-4691: Added PHP 8.2 to CI check & unsupport PHP 7.4 (#50)

spryker-sdk · Oct 6, 2023 · 9a8dece · 9a8dece
1 parent 6252761
commit 9a8dece
Show file tree

Hide file tree

Showing 7 changed files with 18 additions and 10 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -19,7 +19,8 @@ jobs:
       fail-fast: false
       matrix:
         php-version: [
-            '7.4'
+            '7.4',
+            '8.2'
         ]
 
     steps:
@@ -52,7 +53,12 @@ jobs:
         run: composer --version
 
       - name: Composer install
-        run: composer install
+        run: |
+          if [[ ${{ matrix.php-version }} == '8.2' ]]; then
+            composer update --prefer-stable --optimize-autoloader
+          else
+            composer install --optimize-autoloader
+          fi
 
       - name: Container lint
         run: bin/console lint:container

diff --git a/config/checkers.yaml b/config/checkers.yaml
@@ -1,6 +1,6 @@
 parameters:
     # PHP version checker. Must be only major versions. Example: [5, 7, 8]
-    php_version_checker_allowed_php_major_versions: ['7', '8']
+    php_version_checker_allowed_php_major_versions: ['8']
     php_version_checker_sdk_php_major_versions: '%php_version_checker_allowed_php_major_versions%'
 
     php_version_checker_doc_url: https://docs.spryker.com/docs/scos/dev/guidelines/keeping-a-project-upgradable/upgradability-guidelines/php-version.html

diff --git a/src/Filesystem/Filesystem.php b/src/Filesystem/Filesystem.php
@@ -59,8 +59,9 @@ protected static function box(string $func, ...$args)
         }
 
         static::$lastError = null;
-
-        set_error_handler([static::class, 'handleError']);
+        /** @var callable $callback */
+        $callback = [static::class, 'handleError'];
+        set_error_handler($callback);
         try {
             return $func(...$args);
         } finally {

diff --git a/tests/Acceptance/Checker/PhpVersionCheckerTest.php b/tests/Acceptance/Checker/PhpVersionCheckerTest.php
@@ -28,7 +28,7 @@ class PhpVersionCheckerTest extends ApplicationTestCase
      */
     public function testReturnSuccessOnValidProject(): void
     {
-        $commandTester = $this->createCommandTester(TestHelper::VALID_PROJECT_PATH, ['PROJECT_PHP_VERSION' => '7.3.4']);
+        $commandTester = $this->createCommandTester(TestHelper::VALID_PROJECT_PATH, ['PROJECT_PHP_VERSION' => '8.1']);
         $commandTester->execute(['--checkers' => PhpVersionChecker::NAME]);
 
         $commandTester->assertCommandIsSuccessful();
@@ -66,7 +66,7 @@ public function testReturnViolationWhenProjectHasIssues(): void
         | 5 | Not all the targets have same PHP versions                                  | Current php version $phpVersion: -                           |
         |   |                                                                             | tests/Acceptance/_data/InvalidProject/composer.json: - |
         |   |                                                                             | tests/Acceptance/_data/InvalidProject/deploy**.yml: -  |
-        |   |                                                                             | SDK php versions: php7, php8                           |
+        |   |                                                                             | SDK php versions: php8                                 |
         +---+-----------------------------------------------------------------------------+--------------------------------------------------------+
 
         Read more: https://docs.spryker.com/docs/scos/dev/guidelines/keeping-a-project-upgradable/upgradability-guidelines/php-version.html

diff --git a/tests/Acceptance/_data/ValidProject/deploy.dev.yml b/tests/Acceptance/_data/ValidProject/deploy.dev.yml
@@ -5,7 +5,7 @@ tag: 'dev'
 
 environment: docker.dev
 image:
-    tag: spryker/php:7.4-alpine3.12
+    tag: spryker/php:8.1-alpine3.12
     php:
         enabled-extensions:
             - blackfire

diff --git a/tests/Acceptance/_data/ValidProject/deploy.stag.yml b/tests/Acceptance/_data/ValidProject/deploy.stag.yml
@@ -4,7 +4,8 @@ namespace: spryker_b2c_dev
 tag: 'stag'
 
 environment: docker.staging
-image: spryker/php:7.4-alpine3.12
+image:
+    tag: spryker/php:8.2-alpine3.12
 
 composer:
     mode: ''

diff --git a/tests/Acceptance/_data/ValidProject/deploy.yml b/tests/Acceptance/_data/ValidProject/deploy.yml
@@ -5,7 +5,7 @@ tag: '1.0'
 
 environment: docker.production
 image:
-    tag: spryker/php:7.4-alpine3.12
+    tag: spryker/php:8.0-alpine3.12
     php:
         ini:
             "opcache.revalidate_freq": 0