Release 1.0.0 #1

vhrychenko · 2018-08-21T12:23:40Z

Developer(s): @vhrychenko
Peer Reviewer:
Tickets:
https://spryker.atlassian.net/browse/ECO-1924
Academy PR:

Please confirm

No new OS components - or they have been approved by the legal department
All new or heavily changed classes get an "A" rating (Scrutinizer), except Facades, Factories, QueryContainers and Tests

Documentation

Functional documentation provided or in progress?
Integration guide for projects provided or not needed?
Migration guides for all contained majors provided or not needed?

Release Table

Module	Release Type	Constraints
Sevensenders	major

Release Notes

1.0.0 version for sevensenders module.

Module Sevensenders

Patch: Backwards-compatible bug fix

Def of done (by the responsible developer):

All changes are backwards-compatible. The outdated code is marked as deprecated.
The change is isolated and not mixed with any cleanups or other changes.
New code fits the architecture rules.
All new or changed business logic is covered by functional tests (in Zed business layer).

Change log

1.0 version for Sevensenders module.

dereuromark · 2018-08-21T12:27:36Z

Please link the release group in the template, as well, for easier access to it.

dereuromark · 2018-08-21T12:28:26Z

.scrutinizer.yml

+build:
+    dependencies:
+        before:
+            - composer config repositories.spryker composer https://code.spryker.com/repo/private


This is not needed, and even wrong.
Please use current template.

dereuromark · 2018-08-21T12:28:52Z

composer.json

+    "spryker/testify": "*"
+  },
+  "autoload": {
+    "psr-0": {


psr-4 must be used since end of 2017

dereuromark · 2018-08-21T12:29:45Z

src/SprykerEco/Zed/Sevensenders/Business/Api/Adapter/AdapterInterface.php

+
+/**
+ * MIT License
+ * Use of this software requires acceptance of the Evaluation License Agreement. See LICENSE file.


This is using the wrong license. Please check with current specs on .license file for MIT.

dereuromark · 2018-08-21T12:30:07Z

src/SprykerEco/Zed/Sevensenders/Business/Handler/OrderHandler.php

+    public $adapter;
+
+    /**
+     * @var \SprykerEco\Zed\Sevensenders\Dependency\Facade\SevensendersToSalesFacadeBridge


Must be the interface.
Please run in level 5 of phpstan, this would find the issues.

dereuromark · 2018-08-21T12:31:02Z

src/SprykerEco/Zed/Sevensenders/Business/Helper/TokenHelperInterface.php

+     * @return bool
+     */
+    public function isTokenValid(SevensendersTokenTransfer $tokenTransfer): bool;
+}


please run code sniffer and setup your IDE properly: The newline missing warnings should not be here.

dereuromark · 2018-08-21T12:32:51Z

src/SprykerEco/Zed/Sevensenders/Business/SevensendersFacade.php

+
+/**
+ * @method \SprykerEco\Zed\Sevensenders\Business\SevensendersBusinessFactory getFactory()
+ * @method \SprykerEco\Zed\Sevensenders\Persistence\SevensendersRepositoryInterface getRepository()()


invalid () syntax.

dereuromark · 2018-08-21T12:58:02Z

composer.json

@@ -23,7 +23,7 @@
  },
  "minimum-stability": "dev",
  "autoload-dev": {
-    "psr-0": {
+    "psr-4": {


that is not how psr-4 works. please check other modules on the proper changes for it.

dereuromark · 2018-08-28T13:53:01Z

composer.json

@@ -16,7 +16,7 @@
    "spryker/testify": "*"
  },
  "autoload": {
-    "psr-0": {
+    "psr-4": {


That is not how psr-4 works!

I've already known it. I should change my branches quickly and I couldn't find the right way earlier

dereuromark · 2018-08-29T08:16:44Z

src/SprykerEco/Zed/Sevensenders/Dependency/Service/SevensendersToUtilEncodingServiceBridge.php

+    }
+
+    /**
+     * @param mixed $value


If you know you only work with array you can say that here.

dereuromark · 2018-08-29T08:16:56Z

src/SprykerEco/Zed/Sevensenders/Dependency/Service/SevensendersToUtilEncodingServiceBridge.php

+     * @param int|null $depth
+     * @param int|null $options
+     *
+     * @return mixed|null


If you know you only work with array you can say that here maybe. Check if phpstan is ok with this.

dereuromark · 2018-08-29T08:17:34Z

...prykerEco/Zed/Sevensenders/Dependency/Service/SevensendersToUtilEncodingServiceInterface.php

+interface SevensendersToUtilEncodingServiceInterface
+{
+    /**
+     * @param array $value


I see you already do here :)

dereuromark · 2018-08-29T08:17:40Z

...prykerEco/Zed/Sevensenders/Dependency/Service/SevensendersToUtilEncodingServiceInterface.php

+     * @param int|null $depth
+     * @param int|null $options
+     *
+     * @return mixed|null


dereuromark · 2018-08-29T09:09:40Z

src/SprykerEco/Zed/Sevensenders/Dependency/Service/SevensendersToUtilEncodingServiceBridge.php

     */
-    public function decodeJson($jsonValue, $assoc = true, $depth = null, $options = null)
+    public function decodeJson($jsonValue, $assoc = true, $depth = null, $options = null): array


I wouldnt typehint. The doc blocks are still array|null as null can be returned.

alex-galych · 2018-08-29T16:05:43Z

src/SprykerEco/Zed/Sevensenders/Business/Api/Adapter/SevensendersApiAdapter.php

+        ])->getBody()->getContents());
+
+        if (!array_key_exists(static::RESPONSE_KEY_TOKEN, $response)) {
+            throw new SevensendersApiBadCredentialsException('Bad credentials', 401);


Move 401 to constant

vhrychenko added 12 commits August 14, 2018 18:08

ECO-1924 Add composer.json

6ffd85f

ECO-1924 Default adapters and module files

76802d0

ECO-1924 Update adapters

f8425eb

ECO-1924 Add order handler skeleton + interface

c122309

ECO-1924 Auth and shipment handlers

cf07ea8

ECO-1924 Create shipment and order mappers

a0364fc

ECO-1924 Create propel scheme

bcee535

ECO-1924 Update propel scheme

8efc925

ECO-1924 Update propel scheme

95491dc

ECO-1924 Updates

6a4ad59

ECO-1924 Token helper / auth helper updates

63c67f1

ECO-1924 CI

e988f0b

dereuromark reviewed Aug 21, 2018

View reviewed changes

composer.json Outdated

"spryker/testify": "*"

},

"autoload": {

"psr-0": {

Copy link

Contributor

dereuromark Aug 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

psr-4 must be used since end of 2017

dereuromark reviewed Aug 21, 2018

View reviewed changes

vhrychenko changed the title ~~Release 1.0.0~~ [WIP] Release 1.0.0 Aug 21, 2018

dereuromark reviewed Aug 21, 2018

View reviewed changes

vhrychenko added 2 commits August 21, 2018 15:56

ECO-1924 Update CI

ba23561

ECO-1924 Update scrutinizer

8832d40

dereuromark reviewed Aug 21, 2018

View reviewed changes

vhrychenko added 7 commits August 22, 2018 10:57

ECO-1924 Update handlers

18aafad

ECO-1924 Add config

40beb85

ECO-1924 Update auth logic and order handler

3e1a11a

ECO-1924 Update shipping handler

1b35f6f

ECO-1924 EM and refactor handlers

d671e63

ECO-1924 Update oms

36ddd9a

ECO-1924 Tests + licenses

d95c1a8

dereuromark reviewed Aug 28, 2018

View reviewed changes

vhrychenko added 4 commits August 28, 2018 17:59

ECO-1924 Update composer.josn

95b8ee6

ECO-1924 Update end of lines

11bea3b

ECO-1924 Add util encoding service

68c8631

ECO-1924 Remove table for token

e7ae5e0

dereuromark reviewed Aug 29, 2018

View reviewed changes

ECO-1924 Return array and fix tests

9ee002b

dereuromark reviewed Aug 29, 2018

View reviewed changes

ECO-1924 Return array|null

86c250f

vhrychenko changed the title ~~[WIP] Release 1.0.0~~ Release 1.0.0 Aug 29, 2018

alex-galych reviewed Aug 29, 2018

View reviewed changes

vhrychenko added 2 commits October 10, 2018 13:53

eco-1924 Update address mapper

d8154f9

eco-1924 fix customer email value

130634d

alex-galych merged commit 1f8a791 into feature/eco-1924/master-sevensenders Oct 18, 2018

alex-galych deleted the feature/eco-1924/dev-sevensenders branch December 10, 2019 13:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release 1.0.0 #1

Release 1.0.0 #1

vhrychenko commented Aug 21, 2018 •

edited by alex-galych

Loading

dereuromark commented Aug 21, 2018

dereuromark Aug 21, 2018

dereuromark Aug 21, 2018

dereuromark Aug 21, 2018

dereuromark Aug 21, 2018 •

edited

Loading

dereuromark Aug 21, 2018

dereuromark Aug 21, 2018

dereuromark Aug 21, 2018

dereuromark Aug 28, 2018

vhrychenko Aug 28, 2018

dereuromark Aug 29, 2018

dereuromark Aug 29, 2018 •

edited

Loading

dereuromark Aug 29, 2018

dereuromark Aug 29, 2018

dereuromark Aug 29, 2018

alex-galych Aug 29, 2018

Release 1.0.0 #1

Release 1.0.0 #1

Conversation

vhrychenko commented Aug 21, 2018 • edited by alex-galych Loading

Please confirm

Documentation

Release Table

Release Notes

Module Sevensenders

Change log

dereuromark commented Aug 21, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dereuromark Aug 21, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dereuromark Aug 29, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vhrychenko commented Aug 21, 2018 •

edited by alex-galych

Loading

dereuromark Aug 21, 2018 •

edited

Loading

dereuromark Aug 29, 2018 •

edited

Loading