Update webkey:gpg for didkit-wasm #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clehner
force-pushed
the
fix/pgp-rust-wasm
branch
from
f0adfb4
to
311183f
Compare
clehner
force-pushed
the
fix/pgp-rust-wasm
branch
from
311183f
to
c73e6af
Compare
clehner
force-pushed
the
fix/pgp-rust-wasm
branch
from
3ab8394
to
db3fd3e
Compare
At least it's not the other way around, as |
clehner
force-pushed
the
fix/pgp-rust-wasm
branch
from
db3fd3e
to
fb4d8aa
Compare
|
Rebased after #373 squash-merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends #373. Enable use with didkit-wasm in spruceid/didkit#261.
I found it necessary to remove use of
sequoia-openpgpas a feature and optional dependency (c73e6af); this follows the changes in aaae84f which removed the option of usingrpgpas an alternative (since it was not as effective at parsing). This PR also changesdid:webkeyto usesequoia-openpgp/crypto-rustunconditionally (db3fd3e), since architecture-conditional dependency features are not working (#373 (comment)). Note that this PR (as well as #373) adds some redundant use of crypto dependencies, since e.g.ed25519-dalekandrsaare brought in bysequoia-openpgp/crypto-rust, whileringis still used inssi.