Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) Fixed a bug loading the Kotlinx Module without use-fqn variable #733

Merged

Conversation

ctasada
Copy link
Collaborator

@ctasada ctasada commented Apr 29, 2024

When the Kotlinx Serialization Module was available in an environment without the springwolf.use-fqn the code was failing, since it was trying to inject the variable.

The code is now loading the converter only if springwolf.enabled is true (default value). The springwolf.use-fqn is also defaulting to true.

This solution fixes the identified issue.

Copy link

netlify bot commented Apr 29, 2024

Deploy Preview for springwolf-ui canceled.

Name Link
🔨 Latest commit 5de2d74
🔍 Latest deploy log https://app.netlify.com/sites/springwolf-ui/deploys/6633343e9b08010008e8c333

When the Kotlinx Serialization Module was available in an environment without the `springwolf.use-fqn` the code was failing, since it was trying to inject the variable.

The code is now loading the converter **only** if `springwolf.enabled` is `true` (default value). The `springwolf.use-fqn` is also defaulting to `true`.

This solution fixes the identified issue.
@ctasada ctasada force-pushed the ctasada/fix-kotlinx-module-autoconfigure branch from 0c72f78 to 70d8f2d Compare May 1, 2024 11:53
@ctasada ctasada merged commit 4ab6650 into springwolf:master May 3, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants