Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) Add support to parse Annotations from super classes #731

Merged

Conversation

ctasada
Copy link
Collaborator

@ctasada ctasada commented Apr 28, 2024

When a class is inheriting annotated methods from a superclass, the code is now properly parsing those methods for annotations.

This development allows to parse annotations from abstract classes or other inheritance classes, where the annotations are defined in a common class.

Copy link

netlify bot commented Apr 28, 2024

Deploy Preview for springwolf-ui canceled.

Name Link
🔨 Latest commit fdfe867
🔍 Latest deploy log https://app.netlify.com/sites/springwolf-ui/deploys/6631dfad6e2de500085edb3e

@sam0r040
Copy link
Collaborator

Hi @ctasada is this related to #730 ?

When a class is inheriting annotated methods from a superclass, the code is now properly parsing those methods for annotations.

This development allows to parse annotations from abstract classes or other inheritance classes, where the annotations are defined in a common class.
@ctasada ctasada force-pushed the ctasada/support-inherited-methods branch from c9d1967 to fdfe867 Compare May 1, 2024 06:22
@ctasada
Copy link
Collaborator Author

ctasada commented May 1, 2024

Hey @sam0r040 , no, this PR was not intended to fix #730. The issue I'm fixing is when we have the @AsyncListener defined in an abstract class.

@sam0r040
Copy link
Collaborator

sam0r040 commented May 1, 2024

Ahh okay then we need to investigate separately.

@ctasada ctasada merged commit 562818d into springwolf:master May 2, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants