Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix): added annotation for google pubsub message binding #677

Merged
merged 6 commits into from
Apr 6, 2024

Conversation

SheheryarAamir
Copy link
Contributor

Added annotation for google pubsub message binding

Copy link

netlify bot commented Mar 26, 2024

Deploy Preview for springwolf-ui canceled.

Name Link
🔨 Latest commit a87e0f3
🔍 Latest deploy log https://app.netlify.com/sites/springwolf-ui/deploys/661184b707cc3300084e15c2

Copy link
Member

@timonback timonback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition @SheheryarAamir

@timonback
Copy link
Member

Nice addition and improvement of Google PubSub Message bindings. We commented on two things.

@timonback
Copy link
Member

timonback commented Apr 6, 2024

Hi @SheheryarAamir,
I think something broke after the latest commit to springwolf/master branch.
I tried fixing it using various ways while avoiding merge commits.

In the end I arrived at SheheryarAamir#1
It contains your commits squashed and the fix to work with master as a separate commit...
Not sure, how to proceed? Cherry-pick the commit? Open a new PR?

EDIT: I was able to cherry-pick and push it to this branch. Hopefully, the tests are green. I will merge it then.

@timonback timonback merged commit 56f4090 into springwolf:master Apr 6, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants