fix(ui): Make edit header view available by default in ui #649
Conversation
Problem - no schema for headers (varied json) defined in Kafka Listeners. Scenario - user wants to send custom headers in springwolf kafka ui, headers are not defined in schema and changes in internal implementation. Now there are two workarounds to this 1) Define headers for schema using annotations 2) Add example to schema HeadersNotDocumented
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to Springwolf. Thanks a lot for creating your first pull request. Please check out our contributors guide and feel free to join us on discord.
✅ Deploy Preview for springwolf-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hi @victorlev01 , thank you for the contribution. Just to clarify, the issue is not that publishing does not work. |
|
Hi @timonback , thanks for quick response. Yes, the issue is that the header input box is not shown in the ui. On controller side everything works as expected with HeadersNotDocumented. |
|
Perfect, thanks for the clarification. I'll merge it right away and it will be part of the next release 🎉 |
Hello! Thanks for great project!
submitted issue with explaination #650
Problem - no schema for headers without schema in Kafka Listeners (HeadersNotDocumented schema).
Scenario - user wants to send custom headers in springwolf kafka ui, headers are not defined in schema and changes in internal implementation.
Now there are two workarounds to this: