Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear save timeout handler when unmounting the editor. Fix #208 #443

Merged
merged 1 commit into from
Apr 14, 2021
Merged

Clear save timeout handler when unmounting the editor. Fix #208 #443

merged 1 commit into from
Apr 14, 2021

Conversation

thibaudcolas
Copy link
Collaborator

Fixes #208. This is very easily spotted in Storybook by rapidly moving between different stories.

  • Stay on point and keep it small so it can be easily reviewed. For example, try to apply any general refactoring separately outside of the PR.
  • Consider adding unit tests, especially for bug fixes. If you don't, tell us why.
  • All new and existing tests pass, with 100% test coverage (npm run test:coverage)
  • Linting passes (npm run lint)
  • [ ] Consider updating documentation. If you don't, tell us why. Not relevant
  • List the environments / platforms in which you tested your changes. Chrome and Safari on macOS

Thanks for contributing to Draftail!

@thibaudcolas thibaudcolas added the bug Something isn't working label Apr 13, 2021
@thibaudcolas thibaudcolas force-pushed the bug/208-clear-timeout-unmount branch from 9366fc0 to 44c8087 Compare April 14, 2021 07:38
@github-actions
Copy link

Warnings
⚠️ This pull request updates the library. Should the documentation be updated as well?

Generated by 🚫 dangerJS against 44c8087

@springload springload deleted a comment from github-actions bot Apr 14, 2021
@thibaudcolas thibaudcolas merged commit 5c9a53d into main Apr 14, 2021
@thibaudcolas thibaudcolas deleted the bug/208-clear-timeout-unmount branch April 14, 2021 07:45
@thibaudcolas thibaudcolas mentioned this pull request Apr 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

React state update warning – Draftail should clear its save timeout handler when unmounting
1 participant
@thibaudcolas