Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the editor props’ JSDoc annotations #441

Merged
merged 1 commit into from
Apr 11, 2021

Conversation

thibaudcolas
Copy link
Collaborator

This is in preparation for #429, and to improve the experience for setups that already offer some form of inference of props.

There should be no actual change to the props here – just adding annotations.


  • Stay on point and keep it small so it can be easily reviewed. For example, try to apply any general refactoring separately outside of the PR.
  • [ ] Consider adding unit tests, especially for bug fixes. If you don't, tell us why.
  • All new and existing tests pass, with 100% test coverage (npm run test:coverage)
  • Linting passes (npm run lint)
  • Consider updating documentation. If you don't, tell us why.
  • List the environments / platforms in which you tested your changes. Storybook only.

Thanks for contributing to Draftail!

@thibaudcolas thibaudcolas added the enhancement New feature or request label Apr 11, 2021
@thibaudcolas thibaudcolas added this to the v1.4.0 milestone Apr 11, 2021
@thibaudcolas thibaudcolas merged commit b5faaf3 into main Apr 11, 2021
@thibaudcolas thibaudcolas deleted the chore/jsdoc-annotations branch April 11, 2021 23:14
@thibaudcolas thibaudcolas mentioned this pull request Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant