-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for readOnly prop #206
Add support for readOnly prop #206
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @SpearThruster, that was fast 😄 and is looking reeeally close. I’d like the implementation to be slightly different, basically not relying on local state to switch the editor to "readOnly" mode if the prop is used. I think this will make the behavior of this prop more predictable.
Thank you for adding tests as well 🙂I think I’ll also want to add an example of this in Storybook somewhere, but I’m happy to do this myself when merging the changes.
Thanks for the feedback... I updated the code according to your remarks... Will do some npm linking and testing during the next days. When you are OK with the implementation I will also rebase against master. 👍 Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @SpearThruster, this is looking top notch! I spotted a few minor things but I’ll address them while merging.
Merged! 🙂 I’ll be releasing this as part of v1.3.0. I’ll try to get a few more improvements in and release it towards the end of this week. |
Awesome, thanks a lot! :) |
Fixes [#201].