Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is the purpose of media/dialog controls? #26

Closed
loicteixeira opened this issue Nov 17, 2016 · 1 comment
Closed

What is the purpose of media/dialog controls? #26

loicteixeira opened this issue Nov 17, 2016 · 1 comment
Assignees
Labels
question Further information is requested

Comments

@loicteixeira
Copy link

loicteixeira commented Nov 17, 2016

Media and Dialog controls comes from 2 different sets in the options but their implementations are identical. What is the difference then?

@loicteixeira loicteixeira added the question Further information is requested label Nov 17, 2016
@thibaudcolas
Copy link
Collaborator

Long story short – I think they used to be different, and through refactorings they became identical. The other incidental difference is that the media controls are rendered in atomic blocks, whereas the dialog controls are decorators. But that's just what happens / happened to be the case, not a rule set in stone.

This is changed in the latest version.

@thibaudcolas thibaudcolas self-assigned this Jan 15, 2017
@thibaudcolas thibaudcolas added this to the v1.0.0 milestone Jan 15, 2017
@thibaudcolas thibaudcolas modified the milestones: v1.0.0, Wagtail 2.0 Dec 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants