Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newlines overwrite link text when inserting a link #108

Closed
thibaudcolas opened this issue Nov 16, 2017 · 2 comments
Closed

Newlines overwrite link text when inserting a link #108

thibaudcolas opened this issue Nov 16, 2017 · 2 comments
Labels
bug Something isn't working
Milestone

Comments

@thibaudcolas
Copy link
Collaborator

thibaudcolas commented Nov 16, 2017

How to reproduce:

  1. write a sentence
  2. press Shift+Alt+Left
  3. press Link button
  4. choose a link
  5. see that the text is not highlighted anymore
  6. press Enter
  7. newline symbol overwrote the link sentence

Initially reported at springload/wagtaildraftail#20 by @dnsl48.

@thibaudcolas
Copy link
Collaborator Author

I'm having trouble reproducing this, the text correctly stays highlighted in the current master 😞 (outside of Wagtail).

link-text-override

Will try again later, back in Wagtail.

@thibaudcolas
Copy link
Collaborator Author

This is yet another behaviour in the new Wagtail link chooser (the selection collapses to its focus point once the link is inserted), so I'm going to assume this issue was specific to the link chooser's implementation all along and close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant