-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue #767, duplicate @JsonProperty #1045
Conversation
@@ -71,7 +71,7 @@ public String getClientSecret() { | |||
return clientSecret; | |||
} | |||
|
|||
@JsonProperty("apiKey") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apiKey duplicated
@glarfs gaah! thats some copy paste error right there! Thanks for catching that... looks like it has failing tests tho' |
The test on my local branch(which is pointing to master) without this commit and it fails on the same point, it's strange. Seems that the code which is failing test is another commit. |
@glarfs @dilipkrish there are definitely 2 failing tests |
There where an issue with tests, Now the tests are fixed |
Fix issue #767, duplicate @JsonProperty
Thanks! 👍 |
@dilipkrish , do you publish snapshot , RC or milestone builds somewhere? i'm eager to try this :) |
A snapshot is automatically published with every build. Details in our documentation on coordinates of the snapshot versions |
Actually 2.2.2 was a bad build as regards documentation 😖 The snapshot documentation is probably better |
Hi, this fix could be applied also on 2.2.x branch, When are you releasing a new version with this fix? Thanks |
There is a duplicated @JsonProperty on the file, could you integrate it? Please