-
-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for externalizing strings in generated openapi schema via… #2418
Add support for externalizing strings in generated openapi schema via… #2418
Conversation
… properties that follow conventional naming similar to openapi schema.
@bnasslahsen please take a look at this PR and let me know if something requires adjustment |
Thank you for your contribution. I believe it's not yet complete. Do you think you can add the case of OpenAPI groups as well ? |
By "not complete" you mean all fields in the Schema model (like min/max etc.). I didn't plan to add them in the first version, but if you think it makes sense - surely, I'll add it What case and behavior do you mean by supporting groups? E.g. sth like I guess yes, it makes sense when we have identical method names "like getAccount" in UI api and MOBILE api (and in global schema one of them will become |
Sorry for my late response. For the method names, more than 99% of cases they are unique per path and it can be considered for the first MVP. |
ok, now it's my turn to respond with delay... :) do I need to modify some other places for this functionality to appear in the documentation? |
It doesn't seem to me that the groups support is implemented. springdoc.specification-strings.{group-name}.paths.{operationId}.description |
ok, I guess I misunderstood one of the previous messages. Adjusted the logic and added a test-case |
Your push was too fast. |
code merged:
|
Originates from #2401
Can you please hint, what files should be adjusted to publish documentation properly?