-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
db changes #370
db changes #370
Conversation
-> avoid triggering uniqueness constraint on emails with empty strings
I think this is all that goes on the branch, should be ready for db side now |
untested: expect it to blow up the db :-)
did i miss some issue / db change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comments on https://github.com/spring/uberserver/pull/370/files/65e139a69d1682582aadc321dffed09104f8402b..7135ed295a28633623950adc5e7bbe9c29670142#diff-b1dfe5c8d7723f193f507bd9146e1893, unsure if i used the review gui properly...
the new rows (should) be automaticly created when uberserver is started. only changes / deletes / renames needs to be done by hand: the script needs to be run before the changed uberserver is started. |
# Conflicts: # protocol/Protocol.py
I think we are good to go here, I can try it on the test lobbyserver if there is a script somewhere to execute the schema upgrade? |
"cat script.sql | mysql lobbydev" should do the trick. ok, i'll test it as i excpect some errors :-) |
@abma could we get this finished? i can try to test but slightly worried i might break smth. |
meh, i'm to time optimistic. when you do a mysqldump before doing the changes you always can step back... (AFAIK) i.e.: mysqldump lobby > lobby.sql to restore where "lobby" is the database name to backup / recover. so no need to worry about breaking stuff as long the backup is fine :-) |
alright, before i start - would you take a backup that you can restore from, and hide it somewhere that i can't find / accidentally delete, just in case... |
a dump is made daily at ~6:45 am, see /var/backups/mysql/lobby only root has read/write permissions, so... shall i make additionally a manual backup? if so: when? |
I don't think I have access to this so I guess we're safe :p |
hopefully its clear from diff of the structs in SQLUsers.py what needs to be done on db side
https://github.com/spring/uberserver/pull/370/files#diff-898eacbe942e568d1a0f10fa33d4620a
notes:
#359 (comment)
#312 (comment)