Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

db changes #370

Merged
merged 20 commits into from
May 19, 2020
Merged

db changes #370

merged 20 commits into from
May 19, 2020

Conversation

silentwings
Copy link
Contributor

@silentwings silentwings commented Feb 18, 2020

hopefully its clear from diff of the structs in SQLUsers.py what needs to be done on db side

https://github.com/spring/uberserver/pull/370/files#diff-898eacbe942e568d1a0f10fa33d4620a

notes:
#359 (comment)
#312 (comment)

@silentwings silentwings requested a review from abma February 18, 2020 22:13
@silentwings
Copy link
Contributor Author

I think this is all that goes on the branch, should be ready for db side now

untested: expect it to blow up the db :-)
@abma
Copy link
Contributor

abma commented Feb 25, 2020

did i miss some issue / db change?

Copy link
Contributor Author

@silentwings silentwings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scripts/schemaupgrade.sql Outdated Show resolved Hide resolved
scripts/schemaupgrade.sql Outdated Show resolved Hide resolved
scripts/schemaupgrade.sql Outdated Show resolved Hide resolved
scripts/schemaupgrade.sql Show resolved Hide resolved
scripts/schemaupgrade.sql Show resolved Hide resolved
scripts/schemaupgrade.sql Outdated Show resolved Hide resolved
@abma
Copy link
Contributor

abma commented Mar 8, 2020

the new rows (should) be automaticly created when uberserver is started.

only changes / deletes / renames needs to be done by hand:

the script needs to be run before the changed uberserver is started.

@silentwings
Copy link
Contributor Author

silentwings commented Mar 9, 2020

I think we are good to go here, I can try it on the test lobbyserver if there is a script somewhere to execute the schema upgrade?

@abma
Copy link
Contributor

abma commented Mar 9, 2020

"cat script.sql | mysql lobbydev" should do the trick.

ok, i'll test it as i excpect some errors :-)

@silentwings silentwings removed the request for review from abma March 10, 2020 08:53
@silentwings
Copy link
Contributor Author

@abma could we get this finished? i can try to test but slightly worried i might break smth.

@abma
Copy link
Contributor

abma commented May 18, 2020

meh, i'm to time optimistic. when you do a mysqldump before doing the changes you always can step back... (AFAIK) i.e.:

mysqldump lobby > lobby.sql

to restore
cat loby.sql | mysql lobby

where "lobby" is the database name to backup / recover. so no need to worry about breaking stuff as long the backup is fine :-)

@silentwings
Copy link
Contributor Author

silentwings commented May 18, 2020

alright, before i start - would you take a backup that you can restore from, and hide it somewhere that i can't find / accidentally delete, just in case...

@abma
Copy link
Contributor

abma commented May 18, 2020

a dump is made daily at ~6:45 am, see /var/backups/mysql/lobby

only root has read/write permissions, so... shall i make additionally a manual backup?

if so: when?

@silentwings
Copy link
Contributor Author

a dump is made daily at ~6:45 am, see /var/backups/mysql/lobby
only root has read/write permissions, so... shall i make additionally a manual backup?

I don't think I have access to this so I guess we're safe :p

@silentwings silentwings merged commit b9caa2b into master May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants