implement SAYFROM command set (#274) + unify Battle/Channel #282
Conversation
+ associated cleanups
The chat for each battle now takes place in a channel. Channels use for this purpose have names prefixed by __battle__ When a client joins/leaves a battle, he is auto-joined/left to this channel. (-> such channels can register with ChanServ and set a founder, topic, operators, mutes, bans, etc.) To speak in a battle, use SAY/SAYEX/SAYFROM into its channel. -- Changes to protocol -- - JOINBATTLE (server) has an extra arg, containing the name of the channel associated to the battle - removed SAYBATTLEPRIVATE SAYBATTLEPRIVATEEX - deprecated SAYBATTLE SAYBATTLEEX (-> use SAY/SAYEX) - added !registerbattle and !mute/!unmute to ChanServ - deprecated SETCHANNELKEY and ChanServ !lock/!unlock (-> use !setkey) - fix #283: LEFT is reflected back to the user who leaves a channel Clients should send the 'u' compatibility flag to signal that they are prepared for the above. Full backwards compatibility exists for clients lacking 'u'.
+ various related cleaning & re-organization
+ various fixes to channel bans/mutes
|
In the long term - yes, I would want to migrate ChanServ commands to server commands. But, I think what I've done is the best course of action for now. I think ChanServ !cmds shouldn't be removed until lobbies have GUIs to handle it, which isn't going happen soon. When migration of ChanServ commands to server cmds does happen en masse, imo it makes sense to do it at the same time as fixing #58 & #135, which will require a tonne of changes to the battle/channel parts of the protocol anyway (partly because battles would then be identified by their channel name, and the integer battle_id would be removed). I'm not going to do that as part of this PR, this can wait for the future. ChanServ has a similar syntax to SPADS (which will also need small changes), so its natural from the users point of view to have them make greater use of ChanServ, when making Battles & Channels into the same thing. (Chanserv is now present in registered battles.) I've put a lot of work to make ChanServ into a friendlier system, with sensible error messages and cleaner code. My aim here is that game devs can (as channel/battle founder, which is !=host) use ChanServ to control who they set as autohost operators, whilst moderators have the oversight of setting who are the founders. Then bans/mutes/topics will be done server side, and not by SPADS; this is sensible because autohost owners are often long term afk, and the server is on the way to having effective account verification. |
silentwings
changed the title
|
Re MUTE* specifically, I deprecated them because the servers "ChanServ" versions should be CHANNELMUTE* (and similarly for others) -- or perhaps a JSON MUTE cmd that could be integrated with a mod-only global mute; similarly for others. Not sure which I'd favour, but I want to leave this for the future, and for when lobbies have GUIs for it. |
(kicks a user from the game currently being hosted by the client) + simplify callstack for removing a user
restores functionality (that was used by SPADS) from SAYBATTLEPRIVATEEX, but now with a sensible command name
warn about all missing/deprecated/unknown flags deprecate 'm' (does nothing) deprecate 'a' (superseded by 'l') make 'b' optional (only for autohosts)
(inactive channel op user account deleted by scheduled clean)
- disallow users without 'cl' from hosting, rel to #301 - kill off 'p', it was no longer supported in code - kill off 'et', seems never to have been used
|
This is ready for merge / review. |
#274