Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concourse extension doesn't recognize URL for "registry_mirror" with a docker-image resource #831

Closed
guillaumBrisard opened this issue Sep 3, 2022 · 2 comments
Assignees
Labels
for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: concourse-support type: bug

Comments

@guillaumBrisard
Copy link

URL for registry_mirror is not recognize URL for a docker-image resource

The extension wrongly reports for registry_mirror: http://docker-dev-virtual.repository.foo.intra

Expecting a 'Map' but found a 'Scalar'vscode-concourse(YamlSchemaProblem)

The documentation about registry_mirror for resource: https://github.com/concourse/docker-image-resource#source-configuration

@kdvolder
Copy link
Member

kdvolder commented Sep 6, 2022

I reproduced the problem with an example like this:

resources:
- name: testing
  type: docker-image
  source:
    registry_mirror: whatever

It looks like our Schema for that key expects it be something more like a object looking like this:

- name: testing
  type: docker-image
  source:
    repository: aaa
    registry_mirror:
      host: somehost.com
      password: aaa
      username: vvv

I'm not sure where we got that idea from, but clearly it does not agree with the documentation of the resource so it is a mistake.

Should be easy enough to fix.

@kdvolder
Copy link
Member

kdvolder commented Sep 6, 2022

I think we probably simply patterned the schema after the one from 'registry-image': https://github.com/concourse/registry-image-resource, mistakenly assuming it has the same schema.

kdvolder added a commit that referenced this issue Sep 7, 2022
docker-image resource source `registry_mirror` property
schema should allow for just a url rather than host/user/pass object.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: concourse-support type: bug
Projects
None yet
Development

No branches or pull requests

3 participants