Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new validation engine] take preference changes into account beyond open files #1083

Closed
martinlippert opened this issue Jul 26, 2023 · 1 comment
Labels
for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: validation type: enhancement

Comments

@martinlippert
Copy link
Member

The new validation engine (which runs as part of the overall indexing) doesn't react to preference changes yet, which results in diagnostics being published with a certain severity remain unchanged (and don't get re-published) when the user changes the severity of a certain validation.

This even happens across restarts due to the diagnostics being cached. Opening the file updates the diagnostics, but the mechanism should be improved to automatically update corresponding diagnostics if the severity changes for all files.

(follow-up action around new validation engine, based on work done for #1068)

@martinlippert martinlippert added type: enhancement for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: validation labels Jul 26, 2023
@martinlippert martinlippert added this to the 4.20.0.RELEASE milestone Jul 26, 2023
@martinlippert
Copy link
Member Author

Fixed with a93a42f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: validation type: enhancement
Projects
None yet
Development

No branches or pull requests

1 participant