-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes the Javadoc of ClaimAccessor methods for Map/List #10129
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -136,8 +136,9 @@ default URL getClaimAsURL(String claim) { | |
* Returns the claim value as a {@code Map<String, Object>} or {@code null} if it does | ||
* not exist or cannot be assigned to a {@code Map}. | ||
* @param claim the name of the claim | ||
* @return the claim value or {@code null} if it does not exist or cannot be assigned | ||
* to a {@code Map} | ||
* @return the claim value or {@code null} if it does not exist | ||
* @throws IllegalArgumentException If the claim exists, but cannot be converted to a | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For consistency with the rest of the Javadoc, will you please leave "If" lowercased in both of your changes? |
||
* {@code Map} | ||
*/ | ||
@SuppressWarnings("unchecked") | ||
default Map<String, Object> getClaimAsMap(String claim) { | ||
|
@@ -159,8 +160,9 @@ default Map<String, Object> getClaimAsMap(String claim) { | |
* Returns the claim value as a {@code List<String>} or {@code null} if it does not | ||
* exist or cannot be assigned to a {@code List}. | ||
* @param claim the name of the claim | ||
* @return the claim value or {@code null} if it does not exist or cannot be assigned | ||
* to a {@code List} | ||
* @return the claim value or {@code null} if it does not exist | ||
* @throws IllegalArgumentException If the claim exists, but cannot be converted to a | ||
* {@code List} | ||
*/ | ||
@SuppressWarnings("unchecked") | ||
default List<String> getClaimAsStringList(String claim) { | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the copyright message to "2021".