Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spring Security BOM 4.2.14.RELEASE is missing #7975

Closed
davyrod opened this issue Feb 10, 2020 · 8 comments
Closed

Spring Security BOM 4.2.14.RELEASE is missing #7975

davyrod opened this issue Feb 10, 2020 · 8 comments
Assignees
Labels
in: build An issue in the build type: bug A general bug
Milestone

Comments

@davyrod
Copy link

davyrod commented Feb 10, 2020

Summary

Maven build is failing to compile due to missing dependencies when using the spring-security-bom maven artifact.

Actual Behavior

'mvn compile clean install' fails to build when

... org.springframework.security spring-security-bom 4.2.12.RELEASE pom import

is changed to

org.springframework.security spring-security-bom 4.2.14.RELEASE pom import

Expected Behavior

Maven downloads updated artifacts and build succesfully

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 10, 2020
@ghusta
Copy link
Contributor

ghusta commented Feb 21, 2020

In fact the Spring Security BOM artifact is not missing.
What is missing is the dependencyManagement section containing all the dependencies.

@jzheaux jzheaux added this to the 4.2.15 milestone Feb 27, 2020
@jzheaux jzheaux added in: build An issue in the build type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 27, 2020
@rwinch rwinch self-assigned this Mar 30, 2020
rwinch added a commit that referenced this issue Mar 30, 2020
Previously the bom was not being customized for the uploadArchives task.

This commit enhances the bom plugin to support uploadArchives.

Closes gh-7975
@spring-projects-issues
Copy link

Fixed via f892746

@rwinch
Copy link
Member

rwinch commented Mar 30, 2020

Thanks for the report @davyrod and additional details @ghusta. This is related to an update to our Bamboo server which required us making some changes to how things were deployed. The good news is that deployment is now totally independent of Bamboo which allows us to ensure passivity.

A fix has been pushed to 4.2.x and will be released later this week.

@korbel
Copy link

korbel commented Apr 7, 2020

It does not seem to be fixed in 4.2.15
https://search.maven.org/artifact/org.springframework.security/spring-security-bom/4.2.15.RELEASE/jar

@rwinch
Copy link
Member

rwinch commented Apr 7, 2020

Thanks for pointing that out @korbel The changes seem to have fixed it for SNAPSHOTs but not for releases.

<?xml version="1.0" encoding="UTF-8"?>
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
  <modelVersion>4.0.0</modelVersion>
  <groupId>org.springframework.security</groupId>
  <artifactId>spring-security-bom</artifactId>
  <version>4.2.15.BUILD-SNAPSHOT</version>
  <packaging>pom</packaging>
  <name>spring-security-bom</name>
  <description>spring-security-bom</description>
  <url>https://spring.io/spring-security</url>
  <organization>
    <name>spring.io</name>
    <url>https://spring.io/</url>
  </organization>
  <licenses>
    <license>
      <name>The Apache Software License, Version 2.0</name>
      <url>https://www.apache.org/licenses/LICENSE-2.0.txt</url>
      <distribution>repo</distribution>
    </license>
  </licenses>
  <developers>
    <developer>
      <id>rwinch</id>
      <name>Rob Winch</name>
      <email>[email protected]</email>
    </developer>
  </developers>
  <scm>
    <connection>scm:git:git://github.com/spring-projects/spring-security</connection>
    <developerConnection>scm:git:git://github.com/spring-projects/spring-security</developerConnection>
    <url>https://github.com/spring-projects/spring-security</url>
  </scm>
  
  <build>
    <plugins>
      <plugin>
        <artifactId>maven-compiler-plugin</artifactId>
        <configuration>
          <source>1.7</source>
          <target>1.7</target>
        </configuration>
      </plugin>
    </plugins>
  </build>
  <dependencyManagement>
    <dependencies>
      <dependency>
        <groupId>org.springframework.security</groupId>
        <artifactId>spring-security-acl</artifactId>
        <version>4.2.15.BUILD-SNAPSHOT</version>
      </dependency>
      <dependency>
        <groupId>org.springframework.security</groupId>
        <artifactId>spring-security-aspects</artifactId>
        <version>4.2.15.BUILD-SNAPSHOT</version>
      </dependency>
      <dependency>
        <groupId>org.springframework.security</groupId>
        <artifactId>spring-security-cas</artifactId>
        <version>4.2.15.BUILD-SNAPSHOT</version>
      </dependency>
      <dependency>
        <groupId>org.springframework.security</groupId>
        <artifactId>spring-security-config</artifactId>
        <version>4.2.15.BUILD-SNAPSHOT</version>
      </dependency>
      <dependency>
        <groupId>org.springframework.security</groupId>
        <artifactId>spring-security-core</artifactId>
        <version>4.2.15.BUILD-SNAPSHOT</version>
      </dependency>
      <dependency>
        <groupId>org.springframework.security</groupId>
        <artifactId>spring-security-crypto</artifactId>
        <version>4.2.15.BUILD-SNAPSHOT</version>
      </dependency>
      <dependency>
        <groupId>org.springframework.security</groupId>
        <artifactId>spring-security-data</artifactId>
        <version>4.2.15.BUILD-SNAPSHOT</version>
      </dependency>
      <dependency>
        <groupId>org.springframework.security</groupId>
        <artifactId>spring-security-ldap</artifactId>
        <version>4.2.15.BUILD-SNAPSHOT</version>
      </dependency>
      <dependency>
        <groupId>org.springframework.security</groupId>
        <artifactId>spring-security-messaging</artifactId>
        <version>4.2.15.BUILD-SNAPSHOT</version>
      </dependency>
      <dependency>
        <groupId>org.springframework.security</groupId>
        <artifactId>spring-security-openid</artifactId>
        <version>4.2.15.BUILD-SNAPSHOT</version>
      </dependency>
      <dependency>
        <groupId>org.springframework.security</groupId>
        <artifactId>spring-security-remoting</artifactId>
        <version>4.2.15.BUILD-SNAPSHOT</version>
      </dependency>
      <dependency>
        <groupId>org.springframework.security</groupId>
        <artifactId>spring-security-taglibs</artifactId>
        <version>4.2.15.BUILD-SNAPSHOT</version>
      </dependency>
      <dependency>
        <groupId>org.springframework.security</groupId>
        <artifactId>spring-security-test</artifactId>
        <version>4.2.15.BUILD-SNAPSHOT</version>
      </dependency>
      <dependency>
        <groupId>org.springframework.security</groupId>
        <artifactId>spring-security-web</artifactId>
        <version>4.2.15.BUILD-SNAPSHOT</version>
      </dependency>
    </dependencies>
  </dependencyManagement>
</project>

@rwinch rwinch reopened this Apr 7, 2020
@rwinch rwinch modified the milestones: 4.2.15, 4.2.16 Apr 7, 2020
rwinch added a commit that referenced this issue May 6, 2020
@spring-projects-issues
Copy link

Fixed via a302106

@rwinch
Copy link
Member

rwinch commented May 6, 2020

This still failed when being deployed to Central :-/

@rwinch rwinch reopened this May 6, 2020
@rwinch rwinch modified the milestones: 4.2.16, 4.2.17 May 6, 2020
rwinch added a commit that referenced this issue Jun 2, 2020
@spring-projects-issues
Copy link

Fixed via 75e2483

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: build An issue in the build type: bug A general bug
Projects
None yet
Development

No branches or pull requests

6 participants