Skip to content

Commit

Permalink
Fix WebAuthnWebdriverTests
Browse files Browse the repository at this point in the history
Closes gh-16279
  • Loading branch information
Kehrlann authored and rwinch committed Dec 13, 2024
1 parent 2a76a09 commit fb95406
Showing 1 changed file with 5 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;
import org.openqa.selenium.By;
import org.openqa.selenium.WebElement;
Expand Down Expand Up @@ -67,7 +66,6 @@
*
* @author Daniel Garnier-Moiroux
*/
@Disabled
class WebAuthnWebDriverTests {

private String baseUrl;
Expand Down Expand Up @@ -194,6 +192,11 @@ void loginWhenAuthenticatorRegisteredThenSuccess() {
this.driver.findElement(passkeyLabel()).sendKeys("Virtual authenticator");
this.driver.findElement(registerPasskeyButton()).click();

// Ensure the page location has changed before performing further assertions.
// This is required because the location change is asynchronously performed in
// javascript, and performing assertions based on this.driver.findElement(...)
// may result in a StaleElementReferenceException.
await(() -> assertThat(this.driver.getCurrentUrl()).endsWith("/webauthn/register?success"));
await(() -> assertHasAlertStartingWith("success", "Success!"));

List<WebElement> passkeyRows = this.driver.findElements(passkeyTableRows());
Expand Down

0 comments on commit fb95406

Please sign in to comment.