Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate tests to JUnit 5 #360

Closed
wants to merge 2 commits into from
Closed

Migrate tests to JUnit 5 #360

wants to merge 2 commits into from

Conversation

arey
Copy link
Contributor

@arey arey commented Oct 10, 2018

No description provided.

dsyer
dsyer reviewed Jun 5, 2019
View reviewed changes
pom.xml
@@ -103,6 +110,18 @@
</dependency>
<!-- end of webjars -->

<!-- Testing -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You wouldn't need these with Spring Boot 2.2. Maybe we should make this a 2.2 change?

The exclusion above is unnecessary then as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine, it will simply the XML configuration.
If you want, to remember it, I can create an issue in prevision of the Spring Boot 2.2 upgrade.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. That would be great.

@arey
Merge branch 'master' into feature/junit5
dcc4a50 
# Conflicts:
#	src/test/java/org/springframework/samples/petclinic/owner/PetTypeFormatterTests.java
@arey arey mentioned this pull request Jun 11, 2019
Closed
@arey
Copy link
Contributor Author

arey commented Jun 11, 2019

@dsyer I've traced this into the issue #422

@snicoll snicoll self-assigned this Oct 20, 2019
@snicoll snicoll changed the title Migrating from JUnit 4 to JUnit 5 Migrate tests to JUnit 5 Oct 20, 2019
snicoll pushed a commit that referenced this pull request Oct 20, 2019
@arey @snicoll
Migrate tests to JUnit 5
ac69dbb 
See gh-360
snicoll added a commit that referenced this pull request Oct 20, 2019
@snicoll
Polish "Migrate tests to JUnit 5"
253e6fd 
See gh-360
@snicoll snicoll closed this in 6e4c31c Oct 20, 2019
@arey arey deleted the feature/junit5 branch October 20, 2019 18:20
@arey
Copy link
Contributor Author

arey commented Oct 22, 2019

Thank you Stéphane

YKarychkovskyi-GridDynamics pushed a commit to YKarychkovskyi-GridDynamics/spring-petclinic that referenced this pull request Jan 8, 2020
@arey @YKarychkovskyi-GridDynamics
Migrate tests to JUnit 5
5bf015c 
See spring-projectsgh-360
YKarychkovskyi-GridDynamics pushed a commit to YKarychkovskyi-GridDynamics/spring-petclinic that referenced this pull request Jan 8, 2020
@snicoll @YKarychkovskyi-GridDynamics
Polish "Migrate tests to JUnit 5"
9b14420 
See spring-projectsgh-360
marceloklein added a commit to marceloklein/spring-petclinic that referenced this pull request May 25, 2020
@marceloklein @snicoll
@arey @dsyer @jelliotartz
Pull from fork (#4)
03c6485 
* Upgrade to Spring Boot 2.2.0.RELEASE

* Migrate tests to JUnit 5

See spring-projectsgh-360

* Polish "Migrate tests to JUnit 5"

See spring-projectsgh-360

* Fix compatibility with Java 13

This commit upgrades jacoco to 0.8.5 as this version provides Java 13
support.

Closes spring-projectsgh-458

* Update to Spring Boot 2.2.1

* Uncomment sql initialization for mysql

* Add proxyBeanMethods = false

It's slightly faster, and we don't need proxies in this app.

* Spring Boot 2.2.2

* Re-organise mysql scripts so the app runs without root access

It works better that way with test containers and in k8s.

* Fix MySQL docker command line in readme

* Apply spring-format plugin

* Upgrade to Spring Boot 2.2.4

* Upgrade to spring javaformat 0.0.19

* Use https for Maven XSD

See spring-projectsgh-522

* Polish "Use https for Maven XSD"

See spring-projectsgh-522

* Add nohttp check

* Update checkstyle plugin for security scan warning

* Wrong name for user.sql  script

* Add m2e profile for well-known plugins

See spring-projectsgh-519

* Upgrade to Spring Boot 2.2.5

* Upgrade to spring javaformat 0.0.20

* Add support for H2

Closes spring-projectsgh-584

* Disable open-in-view explicitly to remove warning on startup

* Fix typo in readme

See spring-projectsgh-586

* Upgrade to Spring Boot 2.3.0.RC1

* Switch actuator to standard path

* Upgrade to spring javaformat 0.0.21

* Upgrade to maven checkstyle plugin 3.1.1

Co-authored-by: Stephane Nicoll <[email protected]>
Co-authored-by: Antoine Rey <[email protected]>
Co-authored-by: Dave Syer <[email protected]>
Co-authored-by: Dave Syer <[email protected]>
Co-authored-by: vbadipat <[email protected]>
Co-authored-by: James Artz <[email protected]>
marceloklein added a commit to marceloklein/spring-petclinic that referenced this pull request May 25, 2020
@marceloklein @snicoll
@arey @dsyer @jelliotartz
Update to latest (#5)
328a55c 
* fix circleci (#2)

Add circleci

* Jenkins (#3)

* Adding Jenkinsfile

* Pull from fork (#4)

* Upgrade to Spring Boot 2.2.0.RELEASE

* Migrate tests to JUnit 5

See spring-projectsgh-360

* Polish "Migrate tests to JUnit 5"

See spring-projectsgh-360

* Fix compatibility with Java 13

This commit upgrades jacoco to 0.8.5 as this version provides Java 13
support.

Closes spring-projectsgh-458

* Update to Spring Boot 2.2.1

* Uncomment sql initialization for mysql

* Add proxyBeanMethods = false

It's slightly faster, and we don't need proxies in this app.

* Spring Boot 2.2.2

* Re-organise mysql scripts so the app runs without root access

It works better that way with test containers and in k8s.

* Fix MySQL docker command line in readme

* Apply spring-format plugin

* Upgrade to Spring Boot 2.2.4

* Upgrade to spring javaformat 0.0.19

* Use https for Maven XSD

See spring-projectsgh-522

* Polish "Use https for Maven XSD"

See spring-projectsgh-522

* Add nohttp check

* Update checkstyle plugin for security scan warning

* Wrong name for user.sql  script

* Add m2e profile for well-known plugins

See spring-projectsgh-519

* Upgrade to Spring Boot 2.2.5

* Upgrade to spring javaformat 0.0.20

* Add support for H2

Closes spring-projectsgh-584

* Disable open-in-view explicitly to remove warning on startup

* Fix typo in readme

See spring-projectsgh-586

* Upgrade to Spring Boot 2.3.0.RC1

* Switch actuator to standard path

* Upgrade to spring javaformat 0.0.21

* Upgrade to maven checkstyle plugin 3.1.1

Co-authored-by: Stephane Nicoll <[email protected]>
Co-authored-by: Antoine Rey <[email protected]>
Co-authored-by: Dave Syer <[email protected]>
Co-authored-by: Dave Syer <[email protected]>
Co-authored-by: vbadipat <[email protected]>
Co-authored-by: James Artz <[email protected]>

* Enable HTTPS

* updated gradle

Co-authored-by: Stephane Nicoll <[email protected]>
Co-authored-by: Antoine Rey <[email protected]>
Co-authored-by: Dave Syer <[email protected]>
Co-authored-by: Dave Syer <[email protected]>
Co-authored-by: vbadipat <[email protected]>
Co-authored-by: James Artz <[email protected]>
Co-authored-by: Marcelo Klein <[email protected]>
naturkach pushed a commit to naturkach/spring-petclinic that referenced this pull request Mar 31, 2021
@arey @snicoll
Migrate tests to JUnit 5
f1e0264 
See spring-projectsgh-360
naturkach pushed a commit to naturkach/spring-petclinic that referenced this pull request Mar 31, 2021
@snicoll
Polish "Migrate tests to JUnit 5"
463cd70 
See spring-projectsgh-360
naturkach pushed a commit to naturkach/spring-petclinic that referenced this pull request Mar 31, 2021
@snicoll
Merge pull request spring-projects#360 from arey
4d9dae0 
* pr/360:
  Polish "Migrate tests to JUnit 5"
  Migrate tests to JUnit 5

Closes spring-projectsgh-360
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsyer dsyer dsyer left review comments

Assignees

@snicoll snicoll

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arey @dsyer @snicoll