Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix harmless bugs and Rewrite comments #1705

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

wickdynex
Copy link
Contributor

Description

Fix some harmless bugs and rewrite some comments on the method.

For example:

  • Use equals method to substitute == to compare Integer object.
  • Rewrite method's comment to make it easier to use.
  • Remove unnecessary logic to reduce code size and enhance execution time.

Related Issue

None

Type of Change

Please select the type of change you are making:

  • Bug fix (non-breaking change that fixes an issue)
  • Update logic
  • Rewrite document

Additional Information

I've run command mvn test to test this modification🥳, but can't pass all because the postgresql module was wrong🥺. As a result, you can merge it easily into main branch. If confused, plz contact to me. Looking forward to your reply🥰.

@pivotal-cla
Copy link

@wickdynex Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@wickdynex Thank you for signing the Contributor License Agreement!

@dsyer
Copy link
Member

dsyer commented Nov 5, 2024

LGTM. Could you squash it down to a single commit though please?

@wickdynex
Copy link
Contributor Author

LGTM. Could you squash it down to a single commit though please?

Alright, I've squash all the commit into one, if done the code review, plz merge it🤗. Thanks❤️.

@dsyer
Copy link
Member

dsyer commented Nov 5, 2024

You need to squash and rebase and force push to get it down to 1 commit, please. Github currently shows 5 commits.

- <fix>: use `equals` to replace `==` to compare `Integer` variable.
- <delete>: remove redundant 'toLowerCase()' method and simplify pet lookup logic.
- <update>: rewrite method `getName()` comments.
@wickdynex
Copy link
Contributor Author

You need to squash and rebase and force push to get it down to 1 commit, please. Github currently shows 5 commits.

Oh, I've never used this squash feature before, and takes a little time to learn how to use🥺. And finally squash the 6 commits successfully, thanks for your reminder🥳. Btw, I fixed the reversal of equal logic. In my memory, I've fixed this bug, but perhaps due to the wrong operate to use rebase command, maybe I lost the correct modification😵‍💫.

Now, it words as expected like this:
image

Is there anything I can do for this PR? Looking forward to your reply, and also appreciate for your guide🥰.

@dsyer dsyer merged commit fdc40a7 into spring-projects:main Nov 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants