Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Oracle Database in JDBC event publication registry #866

Closed
DSXVII opened this issue Oct 10, 2024 · 2 comments
Closed

Support for Oracle Database in JDBC event publication registry #866

DSXVII opened this issue Oct 10, 2024 · 2 comments
Assignees
@odrotbohm
Labels
in: event publication registry Event publication registry type: enhancement Major enhanvements, new features
Milestone
1.3 RC1

Comments

@DSXVII
Copy link
Contributor

DSXVII commented Oct 10, 2024

Oracle database isn't a supported database type in events-jdbc.
If it's possible, please implement for oracle database.
@DSXVII
Copy link
Contributor Author

DSXVII commented Oct 10, 2024 •
edited
Loading

Hi, I had just implemented oracle database support and test successfully
@odrotbohm PTAL

@DSXVII DSXVII mentioned this issue Oct 10, 2024
Closed
odrotbohm pushed a commit that referenced this issue Oct 11, 2024
@DSXVII @odrotbohm
GH-866 - JDBC event publication support for Oracle database.
5dee1bd 
We now support Oracle as database backend for the JDBC-based EventPublicationRegistry.

Original pull request: GH-868.
odrotbohm added a commit that referenced this issue Oct 11, 2024
@odrotbohm
GH-866 - Polishing.
5733a27 
Switch Oracle schema definition to make the serialized event column non null. Adapt test cases to always contain some content for the serialized event.

Original pull request: GH-868.
@odrotbohm odrotbohm self-assigned this Oct 11, 2024
@odrotbohm odrotbohm added in: event publication registry Event publication registry type: enhancement Major enhanvements, new features labels Oct 11, 2024
@odrotbohm odrotbohm added this to the 1.3 RC1 milestone Oct 11, 2024
@odrotbohm
Copy link
Member

Thanks for that contribution! 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@odrotbohm odrotbohm

Labels
in: event publication registry Event publication registry type: enhancement Major enhanvements, new features
Projects
None yet
Milestone
1.3 RC1
Development

Successfully merging a pull request may close this issue.

GH-866 | implement oracle support to spring-modulith-events-jdbc DSXVII/spring-modulith
2 participants
@odrotbohm @DSXVII